Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed @swill the change is good. What needs to be considered is what
happens with old snapshots, from a older version upgraded to this version, that
are without the .vhd extension. If it can be checked that in a upgraded version
where the older snapshots are without .vhd extension and new ones with .vhd
extension, that cloudstack operations will work fine. Otherwise during upgrade
we need to add .vhd to older snapshots for Xen.
Another thing is that the marvin tests still assume that there is no .vhd
extension and adds it. This needs to be fixed. We were seeing some marvin test
fail on Xenserver due to a additonal .vhd extension. Look at the
test_01_snapshot_root_disk failure for Xen in this PR for example:
https://github.com/apache/cloudstack/pull/1754 and the cause that @serg38
pointed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
