Hello,

I'm not sure, but perhaps we have an 'indirect' blocker for 4.9.1.0 RC1.

Currently the upgrade from 4.9.1.0 RC1 to 4.10.0.0 SNAPSHOT don't works because the schema-481to490.sql in the 4.9.1.0 / 4.9 doesn't contains the commit of CLOUDSTACK-9438 (2e77496601ab5420723ce8b955b3960faaba7d5c).
(this commit is currently in master)

When you try to make the upgrade you have this error: "Unknown column 'image_store_details.display' in 'field list'"
see:  https://issues.apache.org/jira/browse/CLOUDSTACK-9671

Currently there have 2 diff between the schema-481to490.sql in 4.9.1.0 RC1 (and 4.9 branch) and master branch.

What is your opinion: blocker or not?

Just copy the 2 sql request inside the schema-4910to41000.sql file (but the commit 2e77496601ab5420723ce8b955b3960faaba7d5c contains other modified files)?

Milamber



$ diff ./setup/db/db/schema-481to490.sql /tmp/MASTER-schema-481to490.sql
547a548,552
>
> ALTER TABLE `cloud`.`image_store_details` CHANGE COLUMN `value` `value` VARCHAR(255) NULL DEFAULT NULL COMMENT 'value of the detail', ADD COLUMN `display` tinyint(1) NOT > NULL DEFAULT '1' COMMENT 'True if the detail can be displayed to the end user' AFTER `value`;
>
> ALTER TABLE `snapshots` ADD COLUMN `location_type` VARCHAR(32) COMMENT 'Location of snapshot (ex. Primary)';





On 12/12/2016 21:36, Milamber wrote:
Hello,

My vote +1 (binding)

Tests are passed on a virtual topology of servers (CS over CS) (1mgr+2nodes+1nfs) :

1/ Fresh install of 4.9.1.0 RC1 (adv net) on Ubuntu 14.04.5 + KVM + NFS : OK Some standard tests with success (create vm, migration, HA, create networks, create user, create ssh key, destroy vm, register template, create snapshot, restore snapshot, create template, ip association, ip release, static nat, firewall rule) Some tests with cloudstack ansible module with success too (create network, register templates, create vm, ip, firewall rule)

2/ Test upgrade from 4.8.1 to 4.9.1.0 RC1 : OK

3/ Test upgrade from 4.8.2 RC1 to 4.9.1.0 RC1 : don't works (expected)

4/ Tests of all localization Web UI for 4.9.1.0 RC1:
Localization works well except Spanish (not a blocker to release): the Web UI display partially the localization strings due of one bad carriage return in the label message.installWizard.copy.whatIsCloudStack string (from Transifex). This is the same issue that the 4.8.2 RC1.


Perhaps add in the Release notes this Spanish l10n issue.

Thanks to the RM.

Milamber



On 10/12/2016 03:11, Rohit Yadav wrote:
Hi All,

I've created a 4.9.1.0 release, with the following artifacts up for a vote:

Git Branch and Commit SH:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/4.9.1.0-RC20161210T0838
Commit: af2679959b634d095b93b8265c6da294d360065d

List of changes:
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blob_plain;f=CHANGES;hb=4.9.1.0-RC20161210T0838

Source release (checksums and signatures are available at the same
location):
https://dist.apache.org/repos/dist/dev/cloudstack/4.9.1.0/

PGP release keys (signed using 0EE3D884):
https://dist.apache.org/repos/dist/release/cloudstack/KEYS

Vote will be open for 120 hours, considering the process started during the
weekends, and will end on 14 Dec 2016 end of the day.

For sanity in tallying the vote, can PMC members please be sure to indicate
"(binding)" with their vote?

[ ] +1  approve
[ ] +0  no opinion
[ ] -1  disapprove (and reason why)

Regards.




Reply via email to