Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1884#discussion_r95034302
  
    --- Diff: ui/scripts/system.js ---
    @@ -14088,6 +14093,12 @@
                                 }
                             });
                         },
    +                    actionPreFilter: function(args){
    +                        if (g_enablemetricsui)
    +                            return ['add', 'viewMetrics'];
    +                        else
    +                            return ['add'];
    +                    },
    --- End diff --
    
    Lines 14096-14101 appear to be a duplication of lines 7857-7860.  Can this 
code duplication be removed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to