Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1727#discussion_r95516498
--- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java ---
@@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long
vmSnapshotId) throws Insuffici
throw new InvalidParameterValueException("There is other
active vm snapshot tasks on the instance, please try again later");
}
+ revertUserVmDetailsFromVmSnapshot(userVm, vmSnapshotVo);
--- End diff --
Are the details needed in the actual revert snapshot operation? If not then
it is better to do these DB updates after the operation is completed
successfully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
