Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1727
  
    Great job. 
    I just noticed two possible cases that might be a good idea to write a test 
case for.
    
    Test case for method “createAndPersistVMSnapshot” to check when an 
exception for line 388 is thrown. The same for method 
“changeUserVmServiceOffering” when an exception for line 742 is thrown.
    
    The idea is that, if those conditions are met, an exception should be 
accepted; so, it is a test case that prepares the code in a way that those 
conditions are satisfied and an exception is thrown.
    
    I do not know if my explanation was intelligible. If you did not understand 
what I meant, please call me.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to