Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1771#discussion_r101618476
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -3085,9 +3085,10 @@ public GuestVlan
dedicateGuestVlanRange(DedicateGuestVlanRangeCmd cmd) {
// Verify account is valid
Account vlanOwner = null;
if (projectId != null) {
- if (accountName != null) {
- throw new InvalidParameterValueException("accountName and
projectId are mutually exclusive");
- }
+ //accountName and projectId are mutually exclusive
--- End diff --
@nitin-maharana I disagree this change. We'd better keep like it.
I suggest to make ui change to add a new field 'scope' which can be set to
'domain', 'account', 'project'.
It is similar to the scope field in the dialog to create a shared network
in advanced zone.
scope='Domain', domain field is shown.
scope='Account, domain and account are shown
scope='Project', domain and project are shown.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
