Github user sowmyakrishn commented on the issue:
https://github.com/apache/cloudstack/pull/1859
LGTM based on following tests:
Tested with Automated runs for Shared and Dedicated Isolation policies -
test_ncc_integration_dedicated.py and test_ncc_integration_shared.py (also
part of this PR) and both tests have passed.
Result:
====
test_01_shared_first_network
(integration.component.test_ncc_integration_shared.TestNccIntegrationShared)
... === TestName: test_01_shared_first_network | Status : SUCCESS ===
ok
test_02_shared_another_network
(integration.component.test_ncc_integration_shared.TestNccIntegrationShared)
... === TestName: test_02_shared_another_network | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 472.393s
OK
test_01_dedicated_first_network
(integration.component.test_ncc_integration_dedicated.TestNccIntegrationDedicated)
... === TestName: test_01_dedicated_first_network | Status : SUCCESS ===
ok
test_02_dedicated_another_network
(integration.component.test_ncc_integration_dedicated.TestNccIntegrationDedicated)
... === TestName: test_02_dedicated_another_network | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 234.199s
OK
Further, manual tests were also carried out successfully as per the Test
Plan mentioned in
https://cwiki.apache.org/confluence/display/CLOUDSTACK/NCC+Integration+with+CloudStack+Test+Plan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
