Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
I just re-depoyed and re-ran the test:
Test that libvirt properly created domain with scsi controller ... ===
TestName: test_01_verify_libvirt | Status : SUCCESS ===
ok
Verify that libvirt settings are as expected after a VM stop / start
... === TestName: test_02_verify_libvirt_after_restart | Status : SUCCESS ===
ok
Verify that libvirt settings are expected after a disk add ... ===
TestName: test_03_verify_libvirt_attach_disk | Status : SUCCESS ===
ok
Verify that guest sees scsi controller and disks ... === TestName:
test_04_verify_guest_lspci | Status : SUCCESS ===
ok
Update os type to Ubuntu, change vm details rootdiskController ... ===
TestName: test_05_change_vm_ostype_restart | Status : SUCCESS ===
ok
Verify that guest sees scsi controller and disks after switching ostype
and rdc ... === TestName: test_06_verify_guest_lspci_again | Status : SUCCESS
===
ok
----------------------------------------------------------------------
Ran 6 tests in 785.914s
OK
@wido , I believe all of your concerns should be addressed. trim is
enabled, it's using an enum and not a string, and spurious log messages have
been eliminated.
I have squashed all of the commits into one. I'm at a point where I'm
happy with the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
