Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r106188366
--- Diff: server/src/com/cloud/alert/AlertManagerImpl.java ---
@@ -767,7 +767,9 @@ public void sendAlert(AlertType alertType, long
dataCenterId, Long podId, Long c
// set up a new alert
AlertVO newAlert = new AlertVO();
newAlert.setType(alertType.getType());
- newAlert.setSubject(subject);
+ //do not have a seperate column for content.
+ //appending the message to the subject for now.
+ newAlert.setSubject(subject+content);
--- End diff --
I agree with you that we should not try to save the world in a single day.
However, comments in the code for me mean nothing (comments and documentation
are two different things). ACS has a lot of comments saying to improve this or
that, and they just stay there for days, months and years. So, adding a comment
like that does not bring any value to the code. My point is that this specific
case is not a complicated one; it is only a matter of adding a column to a
table, then a new property in a POJO, and setting the correct value in the
newly created property.
The same way I understand that we should not try to save the planet at
once, I also have the philosophy that we should not let to do tomorrow what can
be done today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
