Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111589567
--- Diff: core/src/com/cloud/network/HAProxyConfigurator.java ---
@@ -538,7 +536,7 @@ private String getLbSubRuleForStickiness(final
LoadBalancerTO lbTO) {
if (stickinessSubRule != null && !destsAvailable) {
s_logger.warn("Haproxy stickiness policy for lb rule: " +
lbTO.getSrcIp() + ":" + lbTO.getSrcPort() + ": Not Applied, cause: backends
are unavailable");
}
- if (publicPort.equals(NetUtils.HTTP_PORT) && !keepAliveEnabled ||
httpbasedStickiness) {
+ if (publicPort == NetUtils.HTTP_PORT && !keepAliveEnabled ||
httpbasedStickiness) {
--- End diff --
It is a port number so it should be a Int. It's a part of the NetUtils
refactor. I found that only HTTP/HTTPS port were Strings.
I wanted to make the change in other files as small as possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
