Hi Jayakarteek, It’s been a long time I haven’t look at that code, but I will have a look.
Cheers, Wilder Rodrigues Machine Learning Engineer City AI Ambassador +31 6 5050 2255 https://ekholabs.ai/ <https://ekholabs.ai/> https://amsterdam.city.ai/ <https://amsterdam.city.ai/> > On 14 Feb 2018, at 07:49, Jayakarteek Vasana > <jayakarteek_vas...@accelerite.com> wrote: > > Hi, > > For CLOUDSTACK-8616(https://issues.apache.org/jira/browse/CLOUDSTACK-8616 > <https://issues.apache.org/jira/browse/CLOUDSTACK-8616>) , changes were made > in check_heartbeat.sh.tmpl > > Logic was changed on how the diff time is verified, with the changes the IF > condition ( last time will always be smaller than this time) will fail every > time and the ELSE log will fill the disk space. > > > So can someone check and confirm the logic for the change and whether the > logs are needed in the else part > > https://github.com/apache/cloudstack/pull/587/files#diff-002a85328505af2975427d354a11dbff > > <https://github.com/apache/cloudstack/pull/587/files#diff-002a85328505af2975427d354a11dbff> > > --Jayakarteek > > DISCLAIMER > ========== > This e-mail may contain privileged and confidential information which is the > property of Accelerite, a Persistent Systems business. It is intended only > for the use of the individual or entity to which it is addressed. If you are > not the intended recipient, you are not authorized to read, retain, copy, > print, distribute or use this message. If you have received this > communication in error, please notify the sender and delete all copies of > this message. Accelerite, a Persistent Systems business does not accept any > liability for virus infected mails.