thanks guys On Fri, Feb 8, 2019 at 5:27 PM Gabriel Beims Bräscher <gabrasc...@gmail.com> wrote:
> It looks like we can fix that by applying a "Mock" on the test; I will open > a PR addressing it soon and ping you guys when having it ready for review. > > Em sex, 8 de fev de 2019 às 14:02, Simon Weller <swel...@ena.com> > escreveu: > > > I know Nathan and Gabriel discussed this a couple of weeks ago, as Nathan > > does his dev builds on a mac. I'm not sure if a patch idea came out of > that > > discussion or not. > > > > -Si > > > > > > ------------------------------ > > *From:* Daan Hoogland <daan.hoogl...@gmail.com> > > *Sent:* Friday, February 8, 2019 9:58 AM > > *To:* dev; Wido den Hollander > > *Cc:* Rafael Weingartner; Gabriel Beims Bräscher; Rohit Yadav > > *Subject:* project does not build anymore on macos > > > > LS, > > > > Due to changes in LibvirtResource recently merged, the project will err > out > > during unit tests on macos. This happens because of > > c496c84c6c727a84862cbbe2d870ff57939488b4 that changes the initialisation > of > > memstats, requiring /proc/meminfo to exist (during unit tests). The > > requirement makes perfect sense in production, so a simple roll-back > seems > > not the way to go. @Wido den Hollander <w...@widodh.nl>, you created the > > change, can you think with me what to do here? > > /cc @Rafael Weingartner <rafaelweingart...@gmail.com> @Gabriel Beims > > Bräscher <gabrasc...@gmail.com> @Rohit Yadav <rohityada...@gmail.com> > > > > -- > > Daan > > > -- Daan
