rhtyd commented on a change in pull request #539:
URL: https://github.com/apache/cloudstack-primate/pull/539#discussion_r460701512
##########
File path: src/config/section/event.js
##########
@@ -44,7 +44,9 @@ export default {
ids: {
value: (record) => { return record.id }
}
- }
+ },
+ show: (record, store) => { return
!['User'].includes(store.userInfo.roletype) },
+ groupShow: (record, store) => { return
!['User'].includes(store.userInfo.roletype) }
Review comment:
@davidjumani why not use the show as the implementation is same - the
condition for showing the button can remain same? (or does it conflict with
other views like stop/start vms etc.)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
