davidjumani commented on a change in pull request #558:
URL: https://github.com/apache/cloudstack-primate/pull/558#discussion_r461307402
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -774,6 +780,9 @@ export default {
},
networkName () {
return this.$route.query.name || null
+ },
+ showSecurityGroupSection () {
+ return this.networks.length > 0 && this.zone.securitygroupsenabled &&
this.hypervisor !== 'KVM'
Review comment:
@utchoang Why is KVM excluded for SG Selection ?
##########
File path: src/views/compute/DeployVM.vue
##########
@@ -774,6 +780,9 @@ export default {
},
networkName () {
return this.$route.query.name || null
+ },
+ showSecurityGroupSection () {
+ return this.networks.length > 0 && this.zone.securitygroupsenabled &&
this.hypervisor !== 'KVM'
Review comment:
Got it! But in
https://github.com/apache/cloudstack/blob/master/ui/scripts/ui-custom/instanceWizard.js#L1570
it does support it along with multiple IPs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
