onitake opened a new pull request #17:
URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/17


   As discussed in #8 , these are no longer necessary thanks to the first-class 
module support in Go 1.13+.
   Matching dependency versions is ensured through go.mod and go.sum.
   
   Build and test results:
   ```
   $  make
   go build -ldflags "-X 
k8s.io/kubernetes/pkg/version.gitVersion=0.0.0-master+929042981f203abf8a01ea4271892e4484ca2d7d
 -X 
k8s.io/kubernetes/pkg/version.gitCommit=929042981f203abf8a01ea4271892e4484ca2d7d
 -X k8s.io/kubernetes/pkg/version.buildDate=2020-09-24T14:43:05Z" -o 
cloudstack-ccm cmd/cloudstack-ccm/main.go
   $  ls -sh cloudstack-ccm 
   53M cloudstack-ccm
   $  go vet && echo Pass
   Pass
   $  go test -v
   === RUN   TestReadConfig
   --- PASS: TestReadConfig (0.00s)
   === RUN   TestNewCSCloud
       cloudstack_test.go:89: No config found in environment
   --- SKIP: TestNewCSCloud (0.00s)
   === RUN   TestLoadBalancer
       cloudstack_test.go:101: No config found in environment
   --- SKIP: TestLoadBalancer (0.00s)
   PASS
   ok      github.com/apache/cloudstack-kubernetes-provider        0.005s
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to