[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #755: compute: Back to list VM when deleting VM with the Expunge option.

Mon, 28 Sep 2020 00:24:43 -0700 


davidjumani commented on a change in pull request #755:
URL: https://github.com/apache/cloudstack-primate/pull/755#discussion_r495737105



##########
File path: src/views/compute/DestroyVM.vue
##########
@@ -136,7 +136,7 @@ export default {
             catchMessage: this.$t('error.fetching.async.job.result'),
             successMessage: `${this.$t('message.success.delete.vm')} 
${this.resource.name}`,
             successMethod: () => {
-              if (values.expunge) {
+              if ('id' in this.resource && values.expunge) {

Review comment:
       @utchoang This would return the user back to the dashboard if he tries 
to expunge the vm via Quickview. Could you add a check to go back onlyif the 
url !== '/vm'
   
![b](https://user-images.githubusercontent.com/8244774/94402298-7f21c900-0189-11eb-9ea0-154565c66ff0.jpg)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to