shwstppr commented on a change in pull request #800:
URL: https://github.com/apache/cloudstack-primate/pull/800#discussion_r503880066
##########
File path: src/views/compute/KubernetesServiceTab.vue
##########
@@ -327,14 +327,14 @@ export default {
this.resource.projectid !== '') {
params.projectid = this.resource.projectid
}
- if (this.isValidValueForKey(this.resource, 'associatednetworkid')) {
- params.associatednetworkid = this.resource.associatednetworkid
+ if (this.isValidValueForKey(this.resource, 'networkid')) {
+ params.associatednetworkid = this.resource.networkid
}
}
api('listPublicIpAddresses', params).then(json => {
const ips = json.listpublicipaddressesresponse.publicipaddress
if (this.arrayHasItems(ips)) {
- this.publicIpAddress = ips[0]
+ this.publicIpAddress = ips.filter(x => x.issourcenat)[0]
Review comment:
@davidjumani as Rohit pointed this might break for shared networks as we
don't need source NAT for k8s cluster. Were you able to test that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
