onitake commented on a change in pull request #30:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r622960377
##########
File path: Makefile
##########
@@ -34,7 +34,7 @@ CMD_SRC=\
.PHONY: all clean docker
-all: cloudstack-ccm
+all: clean test cloudstack-ccm
Review comment:
Please don't put that here.
If you think a "all" build should delete build artifacts and run the unit
tests, open a separate PR.
##########
File path: .travis.yml
##########
@@ -4,4 +4,7 @@ go:
- 1.13
- master
-script: make test
+services:
+ - docker
+
+script: make docker
Review comment:
See below.
##########
File path: Dockerfile
##########
@@ -18,7 +18,7 @@
FROM golang:1.13 as builder
COPY . /go/src/github.com/apache/cloudstack-kubernetes-provider
WORKDIR /go/src/github.com/apache/cloudstack-kubernetes-provider
-RUN make clean && CGO_ENABLED=0 GOOS=linux make
+RUN CGO_ENABLED=0 GOOS=linux make
Review comment:
See comment below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
