Pearl1594 opened a new pull request #87:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/87


   This PR prevents adding a newline to the map/list response data for other 
output formats, namely, json, column, table, etc in order to comply with the 
earlier behavior.
   
   #### Prior Fix
   cmk v6.1.0 - Output for csv
   ``` 
   (testenv) 🐱 > set output csv
   (testenv) 🐱 > list virtualmachines 
filter=name,id,hypervisor,nic,details,zoneid
   name,id,hypervisor,nic,details,zoneid
   
VM-3fb3ba0d-8a12-4dfd-98b6-2e00d5e99ec4,3fb3ba0d-8a12-4dfd-98b6-2e00d5e99ec4,VMware,[
   {
   "broadcasturi": "vlan://1468",
   "deviceid": "0",
   "extradhcpoption": [],
   "id": "01fdeb96-c638-41f0-bb04-5a40a836b8be",
   "isdefault": true,
   "isolationuri": "vlan://1468",
   "macaddress": "02:00:21:07:00:02",
   "networkid": "a2db521b-57be-4b7a-bd49-a9cef71dde51",
   "networkname": "test",
   "secondaryip": [],
   "traffictype": "Guest",
   "type": "L2"
   }
   ],{
   "cpuOvercommitRatio": "2.0",
   "dataDiskController": "osdefault",
   "memoryOvercommitRatio": "1.0",
   "rootDiskController": "ide"
   },c80f96f5-f7f9-40b2-aa10-58e34b00a4e4
   
VM-aa3ed00b-99ac-4461-a73c-43e69af9356d,aa3ed00b-99ac-4461-a73c-43e69af9356d,VMware,[
   {
   "broadcasturi": "vlan://1468",
   "deviceid": "0",
   "extradhcpoption": [],
   "id": "7c33b5e5-6899-463f-8a30-c44e66f01b98",
   "isdefault": true,
   "isolationuri": "vlan://1468",
   "macaddress": "02:00:1c:b5:00:01",
   "networkid": "a2db521b-57be-4b7a-bd49-a9cef71dde51",
   "networkname": "test",
   "secondaryip": [],
   "traffictype": "Guest",
   "type": "L2"
   }
   ],{
   "cpuOvercommitRatio": "2.0",
   "dataDiskController": "osdefault",
   "memoryOvercommitRatio": "1.0",
   "rootDiskController": "ide"
   },c80f96f5-f7f9-40b2-aa10-58e34b00a4e4
   
   ```
   
   v5.3.3
   ```
   (testenv) 🐵 > set display csv
   (testenv) 🐵 > list virtualmachines 
filter=name,id,hypervisor,nic,details,zoneid
   zoneid,id,details,nic,name,hypervisor
   
c80f96f5-f7f9-40b2-aa10-58e34b00a4e4,3fb3ba0d-8a12-4dfd-98b6-2e00d5e99ec4,"{u'dataDiskController':
 u'osdefault', u'memoryOvercommitRatio': u'1.0', u'cpuOvercommitRatio': u'2.0', 
u'rootDiskController': u'ide'}","[{u'networkid': 
u'a2db521b-57be-4b7a-bd49-a9cef71dde51', u'macaddress': u'02:00:21:07:00:02', 
u'isolationuri': u'vlan://1468', u'networkname': u'test', u'extradhcpoption': 
[], u'traffictype': u'Guest', u'deviceid': u'0', u'id': 
u'01fdeb96-c638-41f0-bb04-5a40a836b8be', u'secondaryip': [], u'type': u'L2', 
u'broadcasturi': u'vlan://1468', u'isdefault': 
True}]",VM-3fb3ba0d-8a12-4dfd-98b6-2e00d5e99ec4,VMware
   
c80f96f5-f7f9-40b2-aa10-58e34b00a4e4,aa3ed00b-99ac-4461-a73c-43e69af9356d,"{u'dataDiskController':
 u'osdefault', u'memoryOvercommitRatio': u'1.0', u'cpuOvercommitRatio': u'2.0', 
u'rootDiskController': u'ide'}","[{u'networkid': 
u'a2db521b-57be-4b7a-bd49-a9cef71dde51', u'macaddress': u'02:00:1c:b5:00:01', 
u'isolationuri': u'vlan://1468', u'networkname': u'test', u'extradhcpoption': 
[], u'traffictype': u'Guest', u'deviceid': u'0', u'id': 
u'7c33b5e5-6899-463f-8a30-c44e66f01b98', u'secondaryip': [], u'type': u'L2', 
u'broadcasturi': u'vlan://1468', u'isdefault': 
True}]",VM-aa3ed00b-99ac-4461-a73c-43e69af9356d,VMware
   (testenv) 🐵 > 
   
   ```
   
   
   
   Post Fix:
   
   ```
   (testenv) 🐱 > set output csv
   (testenv) 🐱 > list virtualmachines 
filter=name,id,hypervisor,nic,details,zoneid
   name,id,hypervisor,nic,details,zoneid
   
VM-3fb3ba0d-8a12-4dfd-98b6-2e00d5e99ec4,3fb3ba0d-8a12-4dfd-98b6-2e00d5e99ec4,VMware,[{"broadcasturi":"vlan://1468","deviceid":"0","extradhcpoption":[],"id":"01fdeb96-c638-41f0-bb04-5a40a836b8be","isdefault":true,"isolationuri":"vlan://1468","macaddress":"02:00:21:07:00:02","networkid":"a2db521b-57be-4b7a-bd49-a9cef71dde51","networkname":"test","secondaryip":[],"traffictype":"Guest","type":"L2"}],{"cpuOvercommitRatio":"2.0","dataDiskController":"osdefault","memoryOvercommitRatio":"1.0","rootDiskController":"ide"},c80f96f5-f7f9-40b2-aa10-58e34b00a4e4
   
VM-aa3ed00b-99ac-4461-a73c-43e69af9356d,aa3ed00b-99ac-4461-a73c-43e69af9356d,VMware,[{"broadcasturi":"vlan://1468","deviceid":"0","extradhcpoption":[],"id":"7c33b5e5-6899-463f-8a30-c44e66f01b98","isdefault":true,"isolationuri":"vlan://1468","macaddress":"02:00:1c:b5:00:01","networkid":"a2db521b-57be-4b7a-bd49-a9cef71dde51","networkname":"test","secondaryip":[],"traffictype":"Guest","type":"L2"}],{"cpuOvercommitRatio":"2.0","dataDiskController":"osdefault","memoryOvercommitRatio":"1.0","rootDiskController":"ide"},c80f96f5-f7f9-40b2-aa10-58e34b00a4e4
   (testenv) 🐱 >  
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to