sureshanaparti commented on a change in pull request #238:
URL: 
https://github.com/apache/cloudstack-documentation/pull/238#discussion_r699043722



##########
File path: source/adminguide/storage.rst
##########
@@ -661,6 +661,37 @@ The following table shows possible combinations of Service 
offering supported re
    Shrinking the Root disk is not supported via the service offering resizing 
workflow. All the combinations above assume a transition to Root disks with 
size equals or bigger than the original.
    Service Offerings with Root size of 0GB do not change the disk size to Zero 
and indicates that the offering do not enforces a Root disk size.
 
+Change disk offering for volume
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+There are volume operations like migrate volume and resize volume and both 
accepts new disk offering to replace the existing disk offering of volume.
+Instead of those APIs, Disk offering of a volume can be changed directly using 
changeOfferingForVolume API, also supported from UI.

Review comment:
       ```suggestion
   Instead of those APIs, it can be performed directly using change offering 
for volume operation.
   ```
   I think, no need to explicitly mention supported from UI (as the doc is 
primarily with respect to UI)

##########
File path: source/adminguide/storage.rst
##########
@@ -661,6 +661,37 @@ The following table shows possible combinations of Service 
offering supported re
    Shrinking the Root disk is not supported via the service offering resizing 
workflow. All the combinations above assume a transition to Root disks with 
size equals or bigger than the original.
    Service Offerings with Root size of 0GB do not change the disk size to Zero 
and indicates that the offering do not enforces a Root disk size.
 
+Change disk offering for volume
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+There are volume operations like migrate volume and resize volume and both 
accepts new disk offering to replace the existing disk offering of volume.
+Instead of those APIs, Disk offering of a volume can be changed directly using 
changeOfferingForVolume API, also supported from UI.
+Upon changing the disk offering the volume will be resized and/or migrated to 
the suitable storage pool if required according to the new disk offering.
+
+Global setting "match.storage.pool.tags.with.disk.offering" gives flexibility 
or control to choose the new disk offering. 

Review comment:
       ```suggestion
   The zone level setting "match.storage.pool.tags.with.disk.offering", gives 
flexibility or control to choose the new disk offering. 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to