vdombrovski opened a new pull request, #45:
URL: https://github.com/apache/cloudstack-go/pull/45

   All "icon" fields are set to be of resourceiconresponse type, however that 
type is not defined anywhere, making the icon field resolving to a string.
   
   This isn't correct as ACS returns the Icon as an object, which in term 
causes these types of error:
   
   ```sh
   json: cannot unmarshal object into Go struct field 
VirtualMachinesMetric.virtualmachine.icon of type string
   ```
   
   This change sets the type of resourceiconresponse type to be an empty 
interface{}, to guarantee some backward compatibility and ensure that the 
unmarshalling works as intended.
   
   Tested againt ACS 4.17.1
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to