Antonio Gallardo <[EMAIL PROTECTED]> writes:
> 
> Hunsberger, Peter dijo:
> > It appears that if you attempt to close an already closed 
> stream you 
> > get an IO exception.  This means that if Cocoon gets stopped and 
> > restarted it is possible, in at least some circumstances, 
> for Cocoon 
> > to throw an IOException in 
> > org.apache.cocoon.servlet.CocoonServlet.java at line 1205 
> (the current 
> > v 2.1.3 code).  I think that the code should probably swallow the 
> > IOException in this case? Probably something like:
> >
> >             } catch (IOException ie) {
> >                 if ( !"The stream has been closed".equals(
> > ie.getMessage() ) )
> >                     getLogger().error("Cocoon got an 
> Exception while 
> > trying to close stream.", ie);
> >
> > If only to keep the logs clean and not hide any real 
> exception; in our 
> > case we're throwing our own BadSessionException just prior to this.
> 
> Hi Peter:
> 
> +1. This error is related to a client that closed the socket. In fact 
> +this
> is not a Cocoon error. So in this way, maybe we can log it in 
> a lower logger category, maybe INFO will be OK.
> 
> WDYT?
> 

I'm not sure I even see a reason for logging it at INFO?  If you've got
an error that occurs because the client closed the socket you're either
going to know this, or if you turn up logging to the INFO level to try
and find this out you're going to need some way to reproduce the error
that doesn't swamp the log and hope that you the same set of
circumstances once more.  IOW, how would the information ever be useful?


Reply via email to