@@ -143,8 +137,57 @@
logger="sitemap.reader.resource" pool-max="32" pool-min="1" pool-grow="4"/>
<!-- optional reader configuration -->
- <map:parameter name="expires" value="86400000"/>
+ <parameter name="expires" value="86400000"/>
</map:readers>
Why not map:parameter here for consistency sake, like in:
<map:matcher name="mount-table" src="org.apache.cocoon.matching.MountTableMatcher">
<map:parameter name="ignore-missing-tables" value="true"/>
</map:matcher>
?
...
+ <map:read src="images/picture.gif"/> + <map:parameter name="expires" value="86400000"/> + </map:read>
And more general observation: Should we prefer configure(), or parameterize()? Currently, some sitemap components use parameters, and the rest - configuration:
<map:matcher logger="sitemap.matcher.referer-match" name="referer-match" src="org.apache.cocoon.matching.WildcardHeaderMatcher">
<header-name>referer</header-name>
</map:matcher>
<map:matcher name="mount-table" src="org.apache.cocoon.matching.MountTableMatcher">
<map:parameter name="ignore-missing-tables" value="true"/>
</map:matcher>
Classes implementing parameterize(): SetCharacterEncodingAction AntBuildGenerator JMSPublisherAction AbstractProcessingPipeline (and subclasses) TextGenerator XMidiGenerator RequestGenerator SendMailTransformer MountTableMatcher BookmarkAction ProxyTransformer ResourceReader LexicalTransformer ... (48 matches in Cocoon codebase, including non-sitemap components)
Classes implementing configure(): Sendmail SectionCutterAction AbstractControllerAction HttpHeaderAction InputModuleAction LocaleAction PropagatorAction ... (161 matches in Cocoon codebase, lots of them are sitemap components)
Vadim
