Vadim Gritsenko dijo:
I think you are "overformatting" a bit - note changes in license and
broken CVS $Id$
Thanks for reviewing. It is done on CVS.
Thanks :-)
And please keep function arguments aligned after '('.
I am aware of this, what I am trying to do is a "trade off" between showed code in a screen vrs. formatting of the sources. I think it is good to see a method in just 1 screen (in eclipse we have cca. 32 lines per screen - long time ago it was just 25 lines per screen - text consoles). Also there is also a requirement of 80 columns per line. I try to stick to 80 cols per line and also try to see a method in just one screen.
I, for myself, moved to somewhere around 100 characters per line. With long Java identifiers it's not much you can fit in 80 chars ;-)
I had a teacher in the university that endless repeated us:
"If a function cannot be seen in just one screen, then the function is doing too much work. Review the function and try to break it in smaller pieces."
Of course there are some exceptions to the above rule, but are rather rare. (Anyway, it is OT) .... I know it is old wisdom and not sure if is still valid.
I'd say it is valid, with adjustments on size.
Vadim
