Vadim Gritsenko wrote:
+1 from me. I've been using it quite successfully for a while now. Also move TraversableCachedSource, since they make a pair. I haven't yet used the async mode with the DelayRefresher much but I am planning to do so in the following weeks.Hey,
What is left to do before CachedSource can be moved to the core (beside the fact that URL syntax stinks ;-) ? If nothing, how about actually moving it -- anybody against it?
On a related note, I've been planning to propose we move TraversableGenerator (talking about things that stink: that name does too ;-) to the core as well.
I'd also favor moving XPathTraversableGenerator and TraversableDescriptionGenerator there, however the latter would mean we'd have to also find a suitable place for InspectableSource interface...
And, how CachedSource relates to DelayedRefreshSourceWrapper. They do provide slightly different functionality (DelayedRefreshSourceWrapper is subset of CachedSource as it does not consume memory to cache content), but DelayedRefreshSourceWrapper currently provides only programmatic access -- there is no factory for it. So, I think, DelayedRefreshSourceWrapper can be improved by adding a SourceFactory implementation, and CachedSource could extend DelayedRefreshSource, if they overlap enough...
Probably not. I don't think there is much opportunity for code reuse there.
-- Unico
