Upayavira wrote:
Vadim Gritsenko wrote:
Ok, I (majorly) reworked both LocaleAction and I18nMatcher.
Also, I removed "language-attribute", "country-attribute", "variant-attribute" configuration elements from LocaleAction - IMHO they are clear FS - what's the point in customizing sitemap variable names. Language sitemap variable renamed to "language", same as in I18nMatcher.
Fair enough. Although it is a feature removal.
Is it (necessarily) bad? Mentioning in the "Update" doc should be enough.
Please take a look, check that everything is ok :-)
I was thinking: may be I18nMatcher should be renamed to LocaleMatcher?
I had thought of that myself. I'm okay with that too.
I'll go then with renaming it and merging it into the 2.1 branch.
Vadim
