Pier Fumagalli wrote:

On 28 Sep 2004, at 12:00, Vadim Gritsenko wrote:

Go ahead, add parameters.
...
<i:parameter name="name">value</i:parameter>


Done, I'm posting the patch here before applying just to triple-check I'm not f***ing up the whole thing. I mean, it works for me, but do a quick review.

Beside minor nitpicks, looks good :-)


Now, I moved all the inclusion in the EndElement method, and I'm matching parameters in the second format (the easy, non-verbose one). I'm making sure that ALL parameters are nicely URL-encoded, so that we don't have problems down the line, and (in my version), I updated the JavaDOCs quite a lot (including comments and re-indenting of the sources).

Cool

Vadim



Reply via email to