Unico Hommes wrote:
Now only one release blocker remains: NPE in AbstractEnvironment.release()

No, not exactly. As I see it, ResourceReader should return Source's mimeType in this particular case, as per:


    public String getMimeType() {
        Context ctx = ObjectModelHelper.getContext(objectModel);
        if (ctx != null) {
            final String mimeType = ctx.getMimeType(source);
            if (mimeType != null) {
                return mimeType;
            }
        }

        return inputSource.getMimeType();
    }

But in this case, it was not able to get mime type of the SitemapSource. SitemapSource, in its turn, was retrieving mimeType from the environment:

344:                this.mimeType = this.environment.getContentType();

But for some reason it is not there. I think that is the problem and it was a valid test case for this problem. Unless I am mistaken... If I'm not, we should revert the removal of test case.

Vadim


--
Unico

[EMAIL PROTECTED] wrote:

Author: unico
Date: Tue Oct 26 10:07:04 2004
New Revision: 55619

Modified:
cocoon/branches/BRANCH_2_1_X/src/test/anteater/reader-mime-type.xml
cocoon/branches/BRANCH_2_1_X/src/webapp/samples/test/reader-mime-type/explain-test.xml


cocoon/branches/BRANCH_2_1_X/src/webapp/samples/test/reader-mime-type/sitemap.xmap

Log:
remove testcase that no longer complies with expected behavior:

internal requests should not be able to alter response headers
as discussed in http://marc.theaimsgroup.com/?t=109783260100005&r=1&w=2



<snip/>




Reply via email to