Jochen Kuhnle wrote:
Vadim Gritsenko <[EMAIL PROTECTED]> wrote on 06.06.2005 16:19:44:

Jochen Kuhnle wrote:

I noticed that XSPMarkupLanguage.characters wraps text in xsp:text elements. Is there a reason for this? At least my XSPs work without this...

This logic has been there since beginnings of Cocoon2 XSP implementation [1] (line 134), and I'd suggest leaving it there as logicsheets might be dependent on this.

I guess original idea was that text() nodes can be safely ignored, while xsp:text nodes are meaningful. It might be still true, haven't digged deeper...


Hmm, I don't think this behaviour is very intuitive, especially if compared to XSLT's handling of <xsl:text>. Maybe we could make it configurable and deprecate it? Especially if doing so does not break anything?

I don't think that it is something which should be configurable: it should be either left in (and clarified where necessary) or removed. Without review, I can't +1 removal - first need to check that all corner cases are still processed properly without <xsp:text/>.

Vadim

Reply via email to