Sylvain Wallez wrote:

Hi all,

When splitting the XSP block from the core, the getCookie() method that existed (and still exists) on XSPCookieHelper method was copied to ObjectModelHelper as it was also used by *one* class outside of the XSP block, which is DatabaseCookieAuthenticatorAction.

This method has IMO really nothing to do there as ObjectModelHelper is meant to provide high-level access methods to the object model and furthermore the contract of this getCookie() method is weird (mixes named and positional access to cookies).

So I would like to have it removed.

Now it was part of the 2.1.7 release, meaning some people may have used it, despite its weirdness. So I would like to deprecate it at a high level (i.e. error rather than the standard warning) in 2.1.8 and completely remove it in 2.2.

Thoughts?

Sylvain

+1 - That method seems totally inappropriate there.

Reply via email to