[BLOCKER] SQLTransformer bug 1594 - cause found

[Jeremy Quinn]

Hi All

I have been hunting for the cause of this blocker:

        http://issues.apache.org/jira/browse/COCOON-1594





    /**
     * @return Recorded text so far, trimmed.
     */
    public String getText() {
        return this.buffer.toString().trim();
                                     ^^^^^^^
    }



i.e. (from the bug report)

Whereby whitespace gets swallowed up in front of SQLTransformer substitution tags. The cause is in the o.a.c.transformation.helpers.TextRecorder class, line: 45 When this happens in the case of the SQLTransformer, the trailing space in the recorded text is a required part of the SQL statement being generated.

The following code will fail:

<sql:query>
  SELECT id, name, description from department

</sql:query>

After the values are substituted, the output is:
  SELECT id, name, description from department
  LIMITn,m
... instead of
  SELECT id, name, description from department
  LIMIT n,m

LIMIT <substitute-value sql:name="start"/>,<substitute-value sql:name="count"/>

When this is run, with the debugger turned on, you get this message :



I can see two solutions to this bug :






WDYT ?

regards Jeremy

DEBUG (2005-11-02) 17:43.17:351 [sitemap.transformer.sql.query] (/ bug) PoolThread-4/SQLTransformer.Query: Adding query part "SELECT id, name, description from department LIMIT" ^ missing space 1. remove the .trim() from the TextRecorder.getText() method, but I do not know if something else relies on this. 2. Treat SQLTransformer.startSubstituteValueElement (and probably startAncestorValueElement as well) as a special case, and always add a space to the preceding text.

smime.p7s
Description: S/MIME cryptographic signature