[ http://issues.apache.org/jira/browse/COCOON-1780?page=comments#action_12367344 ]
Bruno Dumon commented on COCOON-1780: ------------------------------------- Hi Vincent, It's not really useless code, since it allows more flexibility in rendering. For example, it would allow to use the HTML <button> tag, allowing to put an image on the button. The way I've fixed the Upload widget follows the same pattern as the other widgets do, such as Action. In fact, I looked a bit too much at the Action widget and that's why I got it wrong the first time. > [PATCH] Upload Widget : Can not change selected file > ---------------------------------------------------- > > Key: COCOON-1780 > URL: http://issues.apache.org/jira/browse/COCOON-1780 > Project: Cocoon > Type: Bug > Components: Blocks: Forms > Versions: 2.2-dev (Current SVN), 2.1.9-dev (current SVN) > Reporter: vincent Demay > Assignee: Jean-Baptiste Quenot > Fix For: 2.1.9-dev (current SVN) > > When a file is selected with the upload widget and a on-value-change event is > fired, the value of the widget can not be changed by user. > here is the patch > Index: > /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl > =================================================================== > --- > /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl > (revision 377974) > +++ > /cvs/cocoon/cocoon_BRANCH_2_1_X/src/blocks/forms/java/org/apache/cocoon/forms/resources/forms-field-styling.xsl > (working copy) > @@ -486,7 +486,7 @@ > <xsl:text>[</xsl:text> > <xsl:value-of select="fi:value"/> > <xsl:text>] </xsl:text> > - <input type="button" id="[EMAIL PROTECTED]:input" name="[EMAIL > PROTECTED]" value="..." onclick="forms_submitForm(this)"/> > + <input type="submit" id="[EMAIL PROTECTED]:input" name="[EMAIL > PROTECTED]" value="..." onclick="forms_submitForm(this)"/> > </xsl:when> > <xsl:otherwise> > <input type="file" id="[EMAIL PROTECTED]:input" name="[EMAIL > PROTECTED]" title="{fi:hint}" accept="[EMAIL PROTECTED]"> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
