Pier ping! :-)

Best Regards,

Antonio Gallardo.

Simone Gianni escribió:
Hi Antonio,
you are defitively right, sorry, but since I've not yet been granted
jira rights i didn't noticed i could close that one :)

Could someone grant me jira rights?

Simone

Antonio Gallardo (JIRA) wrote:

[ http://issues.apache.org/jira/browse/COCOON-1685?page=comments#action_12377578 ]
Antonio Gallardo commented on COCOON-1685:
------------------------------------------

You should close this issue if you already committed the fix.

Additional ProcessingPhase.READ_FROM_REQUEST_VALUE event sent
-------------------------------------------------------------

        Key: COCOON-1685
        URL: http://issues.apache.org/jira/browse/COCOON-1685
    Project: Cocoon
       Type: Bug
 Components: Blocks: Forms
   Versions: 2.1.8
   Reporter: Simone Gianni
Attachments: process_initialize.diff

In the Form.process() method, there is a listener.phaseEnded on line 296 which 
sends a LOAD_MODEL_VALUE the first time the form is executed, and a 
READ_FROM_REQUEST_VALUE all the other times. If a ProcessingPhaseListener is 
registered it will receive a READ_FROM_REQUEST_VALUE before the request has 
been processed, and another one after.
IMMO there are the following possible solutions :
- remove this event broadcast.
- send this event only if phase is LOAD_MODEL_VALUE, so that this event takes 
his chance to get broadcasted, while the spurious one doesn't.
- add a "PROCESS_INITIALIZED" phase event and send this one at this point.
I can produce the patch if needed, but don't know which solution is the best 
one.


Reply via email to