[ 
http://issues.apache.org/jira/browse/COCOON-1898?page=comments#action_12431829 
] 
            
Leszek Gawron commented on COCOON-1898:
---------------------------------------

Main sitemap. Not always a block can be tested in total isolation. Just as the 
block may require some servlet filters (e.g. 
hibernate3.OpenSessionInViewFilter) it also might need some additional sitemap 
entries (e.g. mounting external resources).

I do not like the fact that in current patch the directory is located in 
module-dir/conf. I'd like the patch files to be put under 
src/main/resources/META-INF/xpatch. This way they go into the artifact jar and 
then the following scenario is possible:
Every block (say myapp-block-admin-interface, myapp-block-client-interface) 
needs transactions. I define a myapp-block-core block that has an appropriate 
applicationContext.xml (dataSource, transactionManager and such) and xpatch 
file that defines a servlet filter (hibernate3.OpenSessionInViewFilter). 

Simply declaring a dependency on myapp-block-core in 
myapp-block-admin-interface is sufficient to have my web.xml patched for local 
development. When a project has a significant number of modules it is way more 
convenient for the core block to bring xpatch along with itself rather than 
define a xpatch file for each module that needs it.

We could apply the same logic for xpath files as for settings: profiles. Some 
xpatch files will be no matter what. Some will be only applied in development 
mode.

> [PATCH] XPatch support for maven-cocoon-deployer-plugin
> -------------------------------------------------------
>
>                 Key: COCOON-1898
>                 URL: http://issues.apache.org/jira/browse/COCOON-1898
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: - Build System: Maven
>    Affects Versions: 2.2-dev (Current SVN)
>            Reporter: Lars Trieloff
>         Attachments: maven-cocoon-deployer-plugin-with-xpatch-support.patch
>
>
> The cocoon-deployer-plugin has currently no support for XPatch, which makes 
> it difficult to modify the web.xml when developing cocoon blocks. For example 
> the cocoon-xmldb-impl block should add, when deployed, a servlet for xindice 
> and a servlet mapping for the xindice servlet. This was possible in 2.1 using 
> the XConfToolTask, but is no longer possible with the current state of the 
> deployer-plugin.
> My patch adds support for patching the web.xml file using *.xweb files in the 
> /conf directory of a block by filtering the block's jar file during 
> deployment for conf/*.xweb files, caching the patch document temporarily and 
> applying them (using code from the orgiginal XConfToolTask in 2.1) to the 
> web.xml. The patch has currently no support for other files than conf/*.xweb 
> files and does not support any property expansion.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to