Vadim Gritsenko wrote:
[EMAIL PROTECTED] wrote:
Make method getLogger() visible for extending

-    private Log getLogger() {
+    protected Log getLogger() {

Felix,

As far as commons logging usage pattern goes, extending classes should create own instances of the log, otherwise log will get really confusing, with class name of one class and message from another class.

if the getClass() method is used, then extending classes should be safe. It's only problematic when static logging is used, then you're right, that you would log into the category of the parent object.

--
Reinhard Pötz Independent Consultant, Trainer & (IT)-Coach
{Software Engineering, Open Source, Web Applications, Apache Cocoon}

                                       web(log): http://www.poetz.cc
--------------------------------------------------------------------

Reply via email to