[ 
https://issues.apache.org/jira/browse/COCOON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554875
 ] 

Rice Yeh commented on COCOON-1831:
----------------------------------

getValues() is used to implement ServletRequest.getParameterMap() which I 
define it to return all parameters including passed to the current request's 
caller and the caller's caller,...etc.

I have move getValues() to Paramerters class because it is just used by 
Parameters. Also in the original implementation, getNames() always include 
native parameter's names no matter it is in a class Attributes or Header. In 
Attributes, it should include attribute's names. In Headers, it should include 
header's names.

Your approach could fulfill the same purpose since eventually it iterates all 
call frames by recursive way. I just feel iteration is easier for me in 
implementing overriding.

Regards,
Rice



> Passing parameters to sub calls
> -------------------------------
>
>                 Key: COCOON-1831
>                 URL: https://issues.apache.org/jira/browse/COCOON-1831
>             Project: Cocoon
>          Issue Type: New Feature
>          Components: - Servlet service framework
>            Reporter: Reinhard Poetz
>            Assignee: Reinhard Poetz
>         Attachments: BlockCallHttpServletRequest.patch, 
> cocoon-servlet-service-impl.patch, cocoon-servlet-service-impl.patch
>
>
> When a servlet service request is created, parameters from the parent request 
> are ignored. This means that the sub request is performed as a fresh and 
> clean new call. This would avoid any possible side-effects, but is very 
> inconvenient in practice because you don't even know the request header 
> parameters from the original (external) request. Additionally you can only 
> pass information which is part of the returned stream, which is e.g. a  
> blocker to use the servlet protocol together with the control flow 
> implementations. Those make use of special request parameters to transport 
> the model ("bizdata") to the view layer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to