On Thu, 2009-10-15 at 10:06 +0200, Reinhard Pötz wrote: > Thorsten Scherler wrote: > > > > On 13/10/2009, at 23:02, Reinhard Pötz wrote: > > > >> [email protected] wrote: > >>> Author: thorsten > >>> Date: Tue Oct 13 11:33:26 2009 > >>> New Revision: 824705 > >>> > >>> URL: http://svn.apache.org/viewvc?rev=824705&view=rev > >>> Log: > >>> COCOON3-43 > >>> Provide a Consumer that interacts with solr > >>> Reporter and Patch-Provder: Bertil Chapuis > >>> Thanks Bertil. > >>> > >> > >>> + public void characters(char[] ch, int start, int length) > >>> + throws SAXException { > >>> + text += new String(Arrays.copyOfRange(ch, start, start + > >>> length)); > >>> + getSAXConsumer().characters(ch, start, length); > >>> + } > >> > >> Arrays.copyOfRange() comes with JDK 1.6. Can you please replace it with > >> an 1.5 compliant alternative? Thanks! > >> > > > > Good catch, should be fixed now. > > > > Committed revision 824959. > > Thorsten, > > thanks for working on this patch. I've just fixed some problems with > missing license headers. > > In order to spot these errors yourself in the future, you can run it.bat > or it.sh that activate all unit tests, integration tests and license > header checks (RAT plugin). > > I also changed all dependencies of the cocoon-optional module to > <optional>true</optional> so that you do not add all the Solr stuff to > your classpath (or have to manually exclude them) just because you want > to use the FOP serializer for example.
Yeah understood. Thanks very much for the review and I will remember next time to run it.sh. salu2 -- Thorsten Scherler <thorsten.at.apache.org> Open Source Java <consulting, training and solutions> Sociedad Andaluza para el Desarrollo de la Sociedad de la Información, S.A.U. (SADESI)
