I attached the patch. Is this the proper way to submit?
Thanks, and please excuse me my ignorance. It is the first time.
(first times can be traumatic, so far I am feeling well).
Jos
On Sat, 2009-12-05 at 09:28 +0100, Jos Snellings wrote:
> Thank you, Simone. I will do that.
>
> On Sat, 2009-12-05 at 09:21 +0100, Simone Tripodi wrote:
> > Hi Jos,
> > nice to meet you :) Usually suggestions of this kind have to be
> > submitted by the issue tracker:
> >
> > http://issues.apache.org/jira/browse/COCOON3
> >
> > Make your own patch through the command line:
> >
> > svn diff -x -u Main.java > arg-fix.patch
> >
> > giving your patch file meaningful name.
> > Goof job!
> > Simo
> >
> > On Sat, Dec 5, 2009 at 8:29 AM, Jos Snellings <[email protected]>
> > wrote:
> > > URLResponse.java:
> > >
> > > Modifying the finally-clause to remain silent:
> > >
> > > finally {
> > > if (servletConnection != null)
> > > URLConnectionUtils.closeQuietly(servletConnection);
> > > }
> > >
> > > Jos
> > >
> > >
> >
> >
> >
>
>
>
Index: cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/util/URLConnectionUtils.java
===================================================================
--- cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/util/URLConnectionUtils.java (revision 884744)
+++ cocoon3/trunk/cocoon-pipeline/src/main/java/org/apache/cocoon/pipeline/util/URLConnectionUtils.java (working copy)
@@ -34,6 +34,8 @@
* @param urlConnection {...@link URLConnection} to be closed.
*/
public static void closeQuietly(URLConnection urlConnection) {
+
+ if (urlConnection == null) return;
if (urlConnection.getDoInput()) {
InputStream inputStream = null;
try {
