[ 
https://issues.apache.org/jira/browse/COCOON3-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12855766#action_12855766
 ] 

Simone Tripodi commented on COCOON3-54:
---------------------------------------

Thanks for your effort Francesco :)
While applying the patch, I noticed that the 
org.apache.cocoon.sax.component.ToRewrite contains a missing 
org.apache.commons.collections.keyvalue.DefaultMapEntry dependency, that comes 
from commons-collections: unfortunately that violates the principle of the SAX 
module to dependencies-less (only the logging module admitted).

Moreover IMHO
 * checking elements QName could be a risk, since their pattern are 
<namespace_prefix>:<element_name>
 * namespaces that should be checked are attributes namepsaces and not elements 
ones... any thought?

Thanks for working on it!!!

> LinkRewriterTransformer
> -----------------------
>
>                 Key: COCOON3-54
>                 URL: https://issues.apache.org/jira/browse/COCOON3-54
>             Project: Cocoon 3
>          Issue Type: New Feature
>          Components: cocoon-sax
>            Reporter: Francesco Chicchiriccò
>            Assignee: Simone Tripodi
>         Attachments: cocoon3test.tar.gz, LinkRewriterTransformer.patch
>
>
> A LinkRewriterTransformer (like as the old one for Cocoon 2.1, see [1]) could 
> be a very nice addendum to Cocoon 3.
> It could may even by an idea to have a LinkRewriterTransformer<T>, where T is 
> the class performing the actual transformation on links.
> [1] 
> http://cocoon.apache.org/2.1/apidocs/org/apache/cocoon/transformation/LinkRewriterTransformer.html

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to