[ 
https://issues.apache.org/jira/browse/COCOON3-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Francesco Chicchiriccò reopened COCOON3-102:
--------------------------------------------


After some work trying to make profit of this cacheable XIncludeTransformer, 
I've unfortunately come - maybe a little too late - to the conclusion that the 
current implementation couldn't simply work.

In fact, CachingPipeline asks all PipelineComponent for CacheKey instances 
*before* starting the pipeline execution so that it is able to see if there is 
anything in the Cache that can fulfill the current request.
This means that constructCacheKey() method should only build a CacheKey 
including information related to PipelineComponent's attributes and parameters.

This is not the case for XIncludeTransformer: an effective CacheKey should 
include the URLs to be included (<xi:include href="..."/>) but such information 
is available only *after* execution, not when constructCacheKey() is invoked by 
CachingPipeline.
                
> The org.apache.cocoon.sax.component.XIncludeTransformer is not cacheable
> ------------------------------------------------------------------------
>
>                 Key: COCOON3-102
>                 URL: https://issues.apache.org/jira/browse/COCOON3-102
>             Project: Cocoon 3
>          Issue Type: Improvement
>          Components: cocoon-sax
>    Affects Versions: 3.0.0-alpha-3
>            Reporter: Simone Tripodi
>            Assignee: Francesco Chicchiriccò
>             Fix For: 3.0.0-beta-1
>
>
> The org.apache.cocoon.sax.component.XIncludeTransformer is not a cacheable 
> pipeline component, it would be great to implement it as cacheable

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to