On 24/11/2007, Dennis Lundberg <[EMAIL PROTECTED]> wrote: > sebb wrote: > > On 23/11/2007, Oliver Heger <[EMAIL PROTECTED]> wrote: > >> Dennis Lundberg wrote: > >>> Yeah, I just noticed that as well. WTF! I am unable to reproduce it > >>> again, even with an exact copy of the files I built before. > >>> > >>> This is just the source distributions though, so no jars are present in > >>> them. Would it be OK if I repackage the -src.zip and -src.tar.gz files > >>> with the correct path and create new checksums? Or should I do a > >>> complete release cycle once more? > >> Strange. However a new release cycle is not necessary IMO. > > > > Agreed, but please can we have fixed src archives? > > I have created new -src distribution archives. They can be found here: > > http://people.apache.org/~dennisl/commons-logging-1.1.1-5/
Thanks, they look OK. +1 to the release. > They were created by copying the checkout that was made during the last > release cycle. On that copy, I executed the following commands: > > mvn clean > mvn site (this is not necessary for the -src archives, but it is > requried for the -bin archives) > mvn assembly:single > > > Otherwise looks OK. > > > > The staging area has the unnecessary .asc hashes, but they can just be > > deleted before deployment. > > Do you mean the *.asc.md5 and *.asc.sha1 files? Yes. > >> Oliver > >> > >>> Oliver Heger wrote: > >>>> Sorry, just noticed one more thing: The source distributions unpack in > >>>> a directory "commons-logging-2.4.1-src". This version number is really > >>>> future-proof ;-) > >>>> > >>>> Oliver > >>>> > >>>> Oliver Heger wrote: > >>>>> Dennis Lundberg wrote: > >>>>>> Oliver Heger wrote: > >>>>>>> +1 > >>>>>>> > >>>>>>> Some minor remarks (which are not too problematic IMO): > >>>>>>> > >>>>>>> - The format of the md5 files is a bit unusual. Other components > >>>>>>> typically use a format like > >>>>>>> f88520ed791673aed6cc4591bc058b55 *commons-logging-1.1.1-bin.zip > >>>>>> I created them on people.a.o after uploading the files there. > >>>>>> > >>>>>>> - When building the source distribution with maven2 LICENSE and > >>>>>>> NOTICE are not contained in the resulting jar. > >>>>>> Not sure I follow you here. Are you talking about 1) the source > >>>>>> assembly that results in -src.zip and -src.tar.gz archives or 2) the > >>>>>> -sources.jar? > >>>>>> > >>>>>> Both of these contain LICENSE and NOTICE files. > >>>>> I did a mvn package on the unzipped source distribution. The jars > >>>>> created by that (in target) do not contain the files. > >>>>> > >>>>> So the distributions are fine. Only if a user builds his own jar, it > >>>>> does not contain the license. I do not think that this is critical > >>>>> though. > >>>>> > >>>>>>> Oliver > >>>>>>> > >>>>>>> Dennis Lundberg wrote: > >>>>>>>> Hi > >>>>>>>> > >>>>>>>> This is the fourth attempt to release commons-logging 1.1.1. > >>>>>>>> > >>>>>>>> Changes since the last go: > >>>>>>>> - The manifests now has the correct X-Compile-Target-JDK in them > >>>>>>>> - The manifests no longer mention Jakarta > >>>>>>>> - [LOGGING-118] Generate source and binary archives. > >>>>>>>> > >>>>>>>> Release Notes: > >>>>>>>> http://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310484&styleName=Html&version=12312160 > >>>>>>>> > >>>>>>>> > >>>>>>>> Tag: > >>>>>>>> https://svn.apache.org/repos/asf/commons/proper/logging/tags/commons-logging-1.1.1/ > >>>>>>>> > >>>>>>>> > >>>>>>>> Staged repository: > >>>>>>>> http://people.apache.org/~dennisl/staging-repository-commons-logging-4/ > >>>>>>>> > >>>>>>>> > >>>>>>>> Distribution files can be found in this directory: > >>>>>>>> http://people.apache.org/~dennisl/commons-logging-1.1.1-4/ > >>>>>>>> > >>>>>>>> The vote will be open for at least 72 hours. > >>>>>>>> > >>>>>>>> [ ] +1, Let's do it > >>>>>>>> [ ] -1, No, we need to fix this first: > >>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>>> --------------------------------------------------------------------- > >>>>>>> To unsubscribe, e-mail: [EMAIL PROTECTED] > >>>>>>> For additional commands, e-mail: [EMAIL PROTECTED] > >>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>>> --------------------------------------------------------------------- > >>>>> To unsubscribe, e-mail: [EMAIL PROTECTED] > >>>>> For additional commands, e-mail: [EMAIL PROTECTED] > >>>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: [EMAIL PROTECTED] > >>>> For additional commands, e-mail: [EMAIL PROTECTED] > >>>> > >>>> > >>> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > -- > Dennis Lundberg > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
