We should note this change of behavior in the changelog. I am OK with
it, but I think we discussed it a while back and decided not to do it
due to concerns that removing the synch could result in hammering the db
engine with concurrent bursts of createConnection requests when load
spikes happen when maxIdle is used. Personally, I don't see a problem
with this, but we should point it out to users. I will also run some
load tests with db engines I have available.
[email protected] wrote:
Author: markt
Date: Sun Feb 22 19:35:59 2009
New Revision: 746804
URL: http://svn.apache.org/viewvc?rev=746804&view=rev
Log:
DBCP-212. Remove unnecessary sync. Helps a little with connection churn but the
issue remains.
Modified:
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java
Modified:
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java
URL:
http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java?rev=746804&r1=746803&r2=746804&view=diff
==============================================================================
---
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java
(original)
+++
commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java
Sun Feb 22 19:35:59 2009
@@ -294,7 +294,7 @@
_defaultCatalog = defaultCatalog;
}
- synchronized public Object makeObject() throws Exception {
+ public Object makeObject() throws Exception {
Connection conn = _connFactory.createConnection();
if (conn == null) {
throw new IllegalStateException("Connection factory returned null from
createConnection");
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
