Funny - I added that yesterday. But then reverted it as I thought we would not need that :-p
On Sat, Mar 28, 2009 at 14:57, sebb <[email protected]> wrote: > Sorry, posted to wrong list (commons user) originally. > > Please continue any further discussion here - thanks! > > ---------- Forwarded message ---------- > From: Christian Grobmeier <[email protected]> > Date: 28 Mar 2009 12:49 > Subject: Re: [COMPRESS] change IOUtils.copy() to return number of bytes > copied? > To: Commons Users List <[email protected]> > > >> IOUtils.copy() currently returns void. > > If it were changed to return a long of the number of bytes actually > > copied, then it could be used in the ArchiveInputStream test cases to > > check that the EOF was reached after the correct number of bytes. E.g. > > that would show whether any padding was being accidentally included. > > > > The only use of the class in the main code is in the ChangeSet class, > > but of course that does not have to use the return value, and the > > "wasted" code would be minimal. > > > > WDYT? > > > I think this would make sense and feels more consistent. > InputStream.read() returns the number of read bytes. If copy() would > do the same, this feels good to me. > > Christian > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
