On 29/07/2009, Rahul Akolkar <[email protected]> wrote: > On Wed, Jul 29, 2009 at 4:02 PM, <[email protected]> wrote: > > Author: sebb > > Date: Wed Jul 29 20:02:42 2009 > > New Revision: 799042 > > > > URL: http://svn.apache.org/viewvc?rev=799042&view=rev > > Log: > > Add services file for autodiscovery of Jexl script factory > > > > Added: > > commons/proper/jexl/branches/2.0/src/java/META-INF/ > <snip/> > > Have you tried building the jar? Is the result as desired?
Yes. I had to add an Ant task to copy the file > We should really use the standard m2 layout. > > Java sources - src/main/java > Resources - src/main/resources (META-INF would go here) OK. > Test sources - src/test/java > > etc. > > > > commons/proper/jexl/branches/2.0/src/java/META-INF/services/ > > > commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory > > > <snap/> > > I guess it makes sense to set eol-style to native here, though I can > understand why it wasn't auto-prop'ed in. Oops! > > > Added: > commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory > > URL: > http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory?rev=799042&view=auto > > > ============================================================================== > > --- > commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory > (added) > > +++ > commons/proper/jexl/branches/2.0/src/java/META-INF/services/javax.script.ScriptEngineFactory > Wed Jul 29 20:02:42 2009 > > @@ -0,0 +1,19 @@ > > +# > > +# Licensed to the Apache Software Foundation (ASF) under one or more > > +# contributor license agreements. See the NOTICE file distributed with > > +# this work for additional information regarding copyright ownership. > > +# The ASF licenses this file to You under the Apache License, Version 2.0 > > +# (the "License"); you may not use this file except in compliance with > > +# the License. You may obtain a copy of the License at > > +# > > +# http://www.apache.org/licenses/LICENSE-2.0 > > +# > > +# Unless required by applicable law or agreed to in writing, software > > +# distributed under the License is distributed on an "AS IS" BASIS, > > +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > > +# See the License for the specific language governing permissions and > > +# limitations under the License. > > +# > > +# > > + > > +org.apache.commons.jexl.scripting.JexlScriptEngineFactory > > \ No newline at end of file > > > <snip/> > > New line would be better. Will do. > I suspect the above factory class is coming at some point then. Yes, and the engine. Just finishing up the code. > -Rahul > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
