On Aug 19, 2009, at 12:11 AM, Jörg Schaible wrote:
Guys,
I'd like to apply the following change:
=============== %< ================
Index: core/src/test/java/org/apache/commons/AbstractVfsTestCase.java
===================================================================
--- core/src/test/java/org/apache/commons/AbstractVfsTestCase.java
(revision 805676)
+++ core/src/test/java/org/apache/commons/AbstractVfsTestCase.java
(working copy)
@@ -116,13 +116,15 @@
public static String getTestDirectory()
{
- return System.getProperty("test.basedir");
+ String testDirectory = System.getProperty("test.basedir");
+ return testDirectory == null ? "target/test-classes/test-
data" :
testDirectory;
}
- public static String getResourceTestDirectory()
- {
- return System.getProperty("test.basedir.res");
- }
+ public static String getResourceTestDirectory()
+ {
+ String testResourceDirectory =
System.getProperty("test.basedir.res");
+ return testResourceDirectory == null ? "test-data" :
testResourceDirectory;
+ }
/**
* Locates a test directory, creating it if it does not exist.
=============== %< ================
This allows a much easier invoking of the unit tests in Eclipse
without
removing the possibility to use the system properties to overwrite the
defaults. Additionally you can drop any property settings in the POM's
profiles, since they all use these defaults.
This change is fine. I'm not sure that the setting for test.basedir is
used when set in a profile. The test cases for those providers (HTTP,
Webdav, FTP, etc) have overridden getBaseTestFolder to use their own
property.
Ralph
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
