On 26/03/2010, [email protected] <[email protected]> wrote:
> Author: henrib
> Date: Fri Mar 26 16:29:54 2010
> New Revision: 927953
>
> URL: http://svn.apache.org/viewvc?rev=927953&view=rev
> Log:
> Per Sebb's recommendation, made those final.
Actually, I meant that the field
private Integer literal;
should be final, not the classes.
I have no view on whether the classes should be final or not.
> Modified:
>
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java
>
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java
>
> Modified:
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java?rev=927953&r1=927952&r2=927953&view=diff
>
> ==============================================================================
> ---
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java
> (original)
> +++
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTIntegerLiteral.java
> Fri Mar 26 16:29:54 2010
> @@ -16,7 +16,7 @@
> */
> package org.apache.commons.jexl2.parser;
>
> -public class ASTIntegerLiteral extends JexlNode implements
> JexlNode.Literal<Integer> {
> +public final class ASTIntegerLiteral extends JexlNode implements
> JexlNode.Literal<Integer> {
> /** The type literal value. */
> private Integer literal;
>
>
> Modified:
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java?rev=927953&r1=927952&r2=927953&view=diff
>
> ==============================================================================
> ---
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java
> (original)
> +++
> commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/parser/ASTStringLiteral.java
> Fri Mar 26 16:29:54 2010
> @@ -16,7 +16,7 @@
> */
> package org.apache.commons.jexl2.parser;
>
> -public class ASTStringLiteral extends JexlNode implements
> JexlNode.Literal<String> {
> +public final class ASTStringLiteral extends JexlNode implements
> JexlNode.Literal<String> {
>
> public ASTStringLiteral(int id) {
> super(id);
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
