Jochen Wiedmann wrote: > Hi, > > I'd like to ask for a release of commons-fileupload 1.2.2. The > proposed source and binary distributions as well as the KEYS file are > here: > > http://people.apache.org/~jochen/fileupload > > The proposed site is here: > > http://people.apache.org/~jochen/fileupload/site > > The list of changes: > > http://people.apache.org/~jochen/fileupload/site/changes-report.html > > Please cast your vote. > > Thanks, > > Jochen > > [ ] +1 > [ ] =0 > [ ] -1 >
Sigs and hashes are good. Ant and maven builds from source are good. Jar manifest, license, notice look good. A few comments: 1) Maven artifacts - these are not part of the release, IMO; but we usually inspect these artifacts as part of the release vote. It would be good to post or stage these somewhere for inspection prior to publication. 2) The doap file is out of date and should be updated. I see no reason to include this file in the release. 3) I would drop the site from the binary release, including only the apidocs 4) Having the jar in /lib in the binary distro is a little odd. It is usually in the top level directory. 5) It would be nice to include source and javadoc jars None of these are showstoppers. I am fine proceeding with the release of the referenced source and binary distributions. +1 to release. Phil > > -- > Germanys national anthem is the most boring in the world - how telling! > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
