On Mon, Nov 15, 2010 at 11:30 AM, ralph.goers @dslextreme.com < [email protected]> wrote:
> > On Mon, Nov 15, 2010 at 11:12 AM, sebb <[email protected]> wrote: > >> On 15 November 2010 08:58, <[email protected]> wrote: >> > Author: rgoers >> > Date: Mon Nov 15 08:58:37 2010 >> > New Revision: 1035190 >> > >> > URL: http://svn.apache.org/viewvc?rev=1035190&view=rev >> > Log: >> > Sandbox was not dependent on vfs2. Convert many StringBuffers to >> StringBuilder. >> >> That has broken the build, as some public/protected methods still >> expect StringBuffer. >> The methods cannot be changed to use StringBuilder without breaking >> API compatibility. >> > > Broke the build how? I get a clean build of both VFS and Commons > Configuration. The point of changing the package name and artifactId is > that the API is already binary incompatible so this is the correct time to > do this. > > I did not replace all StringBuffers with StringBuilder. I am quite sure there are more that can be converted. However, there are some that are used as member variables in "interesting" ways and I'm not sure that those can/should be changed. Ralph
