> Completing the fix for MATH-414, I saw that ContinuedFraction still throws > MaxIterationsExceededException. I thought it would be good to eliminate the > use of the deprecated exception in trunk, but I got stuck because the > replacement, MaxCountExceededException does not allow the initial argument > to be passed and reported in the message. In ContinuedFraction, we have > {code} > if (n >= maxIterations) { > throw new MaxIterationsExceededException(maxIterations, > LocalizedFormats.NON_CONVERGENT_CONTINUED_FRACTION, > x); > } > {code} > > but MaxIterationsExceededException does not allow x to be passed in. Should > we add a constructor similar to what MaxIterationsExceededException has > taking an Object[] to hold additional message parameters?
I've just committed (revision 1040003) the addition of a vararg parameter to the contructor that takes a "specific" message pattern. I also changed the "NON_CONVERGENT_CONTINUED_FRACTION" pattern in order that the additional argument will actually appear in the message. The exception would thus be used as ---CUT--- new MaxCountExceededException(LocalizedFormats.NON_CONVERGENT_CONTINUED_FRACTION, maxIterations, x); ---CUT--- Gilles --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org