Looks right. I think that the base of the patch is one level too low. It is also a nice convention to name the patch after the JIRA. Thus your patch would be called MATH-448.patch
It is also a nice convention to just upload on top of the previous version. This leaves JIRA with a development history which is pretty interesting to take a look. On Mon, Dec 6, 2010 at 9:03 AM, Patrick Meyer <meyer...@gmail.com> wrote: > I originally used Netbeans to generate the Diff, then copy and pasted it > into Wordpad to save it. I just uploaded a new patch that was created with > the Netbeans "Export Diff Patch" function. Is this new file in the correct > format? (Please excuse the noob - I'll get the process right eventually.) > > > > On Mon, Dec 6, 2010 at 11:55 AM, Ted Dunning <ted.dunn...@gmail.com> > wrote: > > > How did you create this diff? > > > > The normal way is to use svn diff in the project root directory. > > > > On Mon, Dec 6, 2010 at 8:29 AM, Patrick Meyer <meyer...@gmail.com> > wrote: > > > > > OK, I attached a diff file to, > > > https://issues.apache.org/jira/browse/MATH-448. > > > However, I am new to subversion and JIRA and I'm not sure I have done > > this > > > correctly. Please let me know if I have done something wrong. I am > happy > > to > > > volunteer and contribute to the project. I just want to make sure I am > > > using > > > he right process to submit changes. > > > > > > Thanks, > > > Patrick > > > > > > > > > > > > On Mon, Dec 6, 2010 at 10:46 AM, Ted Dunning <ted.dunn...@gmail.com> > > > wrote: > > > > > > > If you provide a suggested patch, this will go forward much more > > quickly > > > > than > > > > if you wait for a volunteer to appear out of the mists. > > > > > > > > It is after all a volunteer effort. Go ahead and volunteer! > > > > > > > > On Mon, Dec 6, 2010 at 6:07 AM, Patrick Meyer <meyer...@gmail.com> > > > wrote: > > > > > > > > > I have a small feature request for the org.apache.commons.math.stat > > > > > Frequency class. It is often useful to know the unique number of > > > elements > > > > > in > > > > > a frequency table. Would you add this feature? I submitted an issue > > > with > > > > > JIRA with the code needed to make this happen, > > > > > https://issues.apache.org/jira/browse/MATH-448. > > > > > > > > > > Thanks > > > > > > > > > > > > > > >
